chroma-core/chroma

[Bug]: type errors in chromadb/utils/embedding_functions.py

Open

#1169 opened on Sep 21, 2023

View on GitHub
 (5 comments) (0 reactions) (1 assignee)Rust (27,958 stars) (2,247 forks)batch import
bugby-chromagood first issue

Description

What happened?

mypy complains about type errors in chromadb/utils/embedding_functions.py, specifically with some __call__ and _normalize methods. See some of the #type: ignores in https://github.com/chroma-core/chroma/pull/1163 for specifics.

It's worth figuring out the correct type annotations for these methods and the methods they call into so that our type checking works as intended.

Versions

Chroma latest, python 3.9.6, macOS

Relevant log output

No response

Contributor guide

Tech stack
python
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python type hintsmypybasic understanding of embedding functions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Look at the referenced PR #1163 for examples of `# type: ignore` comments. Examine the methods ` call ` and ` normalize` in `chromadb/utils/embedding functions.py`. Understand the expected input/output types and correct the annotations to eliminate mypy errors. Check if there are other methods with similar issues.