christophergandrud/networkD3

get back on track with official d3-sankey

Open

#204 opened on Jun 19, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)R (257 forks)batch import
help wantedsankeyNetwork

Repository metrics

Stars
 (565 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The official d3-sankey library has finally gotten some love recently, it even gained an official horizontal alignment feature. Should we consider getting back to tracking the official version? Frankly, I have avoided messing with any of the sankey code here because so many minor changes/additions have been made I'm afraid of messing something up, but we would likely lose some current features.

Maybe we/someone can audit what we have and compare it to the official library and make a list of additional features we have here, so we can assess the cost of losing them or reimplementing them?

Contributor guide

Research direction
Review the current networkD3 sankey implementation and compare it with the official d3 sankey library (https://github.com/d3/d3 sankey). Identify any custom features added in networkD3 and assess their value. Then decide whether to align with the official version, potentially losing or reimplementing those features. Recommend a plan for integration.
Tech stack
javascriptr
Domain
data
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
R programmingD3.js basicsnetwork graph concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20