christopherdro/react-native-calendar

Inconsistency in passing value to callbacks

Open

#54 opened on Jul 19, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (544 stars) (250 forks)batch import
enhancementhelp wanted

Description

I spotted inconsistency in callback values. Namely these: onSwipePrep and onSwipeNext receive moment instance. onDateSelected receives date in plain string format.

Unifying this issue is essentially a breaking change, but it would be nice to be consistent.

Contributor guide

Tech stack
react native
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with react native calendar callbacksknowledge of moment.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the callback implementations in the source code to confirm which callbacks return moment instances and which return strings. The issue specifically mentions onSwipePrep, onSwipeNext, and onDateSelected. The fix would involve changing the callbacks to consistently return either moment objects or strings. Since this is a breaking change, consider adding a new prop or version. The repository is deprecated, so contribution may not be merged.