christianalfoni/formsy-react

Incompatible API changes

Open

#330 opened on Apr 22, 2016

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (423 forks)github user discovery
help wantedquestion

Repository metrics

Stars
 (2,574 stars)
PR merge metrics
 (PR metrics pending)

Description

My suggestions:

  1. Remove automatic validation at start rendering and in setValue.
  2. Rename validate to customValidate.
  3. Add validate method to Form and Mixin for manually validation.

This should make it very easy following scenarios:

  • validate on change
  • validate on blur
  • validate on submit
  • ...

@twisty @mbrookes and other Your opinion is important

Contributor guide

Research direction
Read the linked API documentation and evaluate the impact of renaming `validate` and removing automatic validation. Consider how these changes affect on change, on blur, and on submit validation patterns.
Tech stack
react
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75