cholla-hydro/cholla

Spherical Collapse Particles test is currently failing

Open

#225 opened on Jan 12, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (41 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (74 stars)
PR merge metrics
 (PR metrics pending)

Description

The tPARTICLESSYSTEMSphericalCollapse.CorrectInputExpectCorrectOutput tests is currently failing on both main and dev. Partially fixed in PR #223 and originally discussed in Issue #218

Contributor guide

Research direction
Review the test case for spherical collapse, identify the numerical discrepancy, and compare with the fix in PR #223.
Tech stack
cpp
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++CUDA
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70