chipsalliance/chisel

Incorrect Error Message in Data.connect(...)

Open

#1,170 opened on Sep 3, 2019

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Scala (651 forks)batch import
good first issue

Repository metrics

Stars
 (4,658 stars)
PR merge metrics
 (Avg merge 3d 21h) (16 merged PRs in 30d)

Description

In https://github.com/freechipsproject/chisel3/blob/master/chiselFrontend/src/main/scala/chisel3/Data.scala#L377:

      requireIsHardware(this, "data to be connected")
      requireIsHardware(that, "data to be connected")

The first error message is incorrect. It should be something like left hand side of the connection.

Contributor guide

Research direction
Navigate to chiselFrontend/src/main/scala/chisel3/Data.scala line 377 and change the first error message from 'data to be connected' to 'left hand side of the connection'.
Tech stack
scala
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90