cheeriojs/cheerio

.attr(name) should lowercase name property

Open

#581 opened on Oct 21, 2014

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (28,115 stars) (1,626 forks)batch import
good first issue❌ Bug

Description

When looking up an attribute with .attr(), the name of the attribute should be lowercased before looking up in .attribs object.

Contributor guide

Tech stack
typescript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is about lowercasing the attribute name before looking it up in the .attribs object. The fix should be in the .attr() method implementation. Look at the cheerio source code, likely in lib/api/attributes.js or similar. Ensure that the name parameter is lowercased using .toLowerCase() before accessing .attribs[name]. No linked PRs or comments indicate any blockers.