Prometheus counters are off if a transaction is rolled back.

Open
#182 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
prometheus, rust

Research direction

Start with the linked pull request discussion and trace where Prometheus counters are mutated relative to the transaction boundary. No file or test is named; done means rolled-back transactions no longer leave counters reflecting work that was not committed.

Written by the indexing model from the issue text.

Description

Prometheus counters are off if a transaction is rolled back, because we mutate the counters within the transaction. See https://github.com/channable/opsqueue/pull/132#discussion_r3639207679. Perhaps we should only mutate counters after the transaction is comitted?

Dominant language
Rust
Stars
96
Forks
2
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from channable/opsqueue

All issues in channable/opsqueue

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.