channable/hoff

Maintain one comment per merge request

Open

#45 opened on Jan 27, 2020

View on GitHub
 (0 comments) (5 reactions) (0 assignees)Haskell (4 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (45 stars)
PR merge metrics
 (PR metrics pending)

Description

When an person approves a pull request, Hoff posts a series of comments on the pull request about its progress. This results in many notifications being sent to people involved in the pull request.

Instead, Hoff could remember the ID of the comment it posted, and append to the comment as more progress is made. Only when a person re-approves a pull request should a new comment be posted.

Before:

ruuda @OpsBotPrime merge

OpsBotPrime Pull request approved by @ruuda, rebasing now.

OpsBotPrime Rebased as 1234567, waiting for CI …

OpsBotPrime The build failed.

ruuda @OpsBotPrime merge

OpsBotPrime Pull request approved by @ruuda, rebasing now.

OpsBotPrime Rebased as 9abcdef, waiting for CI …

OpsBotPrime merged commit 9abcdef into master

After:

ruuda @OpsBotPrime merge

OpsBotPrime Pull request approved by @ruuda, rebasing now. Rebased as 1234567, waiting for CI … The build failed.

ruuda @OpsBotPrime merge

OpsBotPrime Pull request approved by @ruuda, rebasing now. Rebased as 9abcdef, waiting for CI …

OpsBotPrime merged commit 9abcdef into master

Contributor guide

Research direction
Explore the Hoff codebase to find where comments are posted and how to store and update a comment ID per pull request.
Tech stack
haskell
Domain
backendclidevops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HaskellGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60