chakra-core/ChakraCore

Chakra failed when build with std:c++latest by msvc on Windows

Open

#6,436 opened on Apr 23, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import
Codebase Qualityhelp wanted

Description

Chakra failed when build with std:c++latest by msvc on Windows. Could you please help take a look at this?

You can repro this issue as the steps below:

  1. git clone -c core.autocrlf=true https://github.com/microsoft/ChakraCore D:\Chakra\src
  2. open a clean VS2019 x86 prompt and browse to D:\Chakra\src
  3. set CL=/std:c++latest
  4. msbuild /m /p:Platform=x86 /p:Configuration=Test /p:WindowsTargetPlatformVersion=10.0.18362.0 Build\Chakra.Core.sln /t:Rebuild

Failures: JsrtContextCore.i JsrtContextCore.i(1558483): error C2220: the following warning is treated as an error JsrtContextCore.i(1558483): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored) JsrtContextCore.i(1558485): warning C4499: 'static an explicit specialization cannot have a storage class (ignored) JsrtContextCore.i(1558487): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)

Contributor guide

Tech stack
cpp
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ basicsMSVC compilermsbuildChakraCore build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the warning C4499 reported on lines 1558483-1558487 of JsrtContextCore.i. The fix likely involves adding a pragma to disable the warning around those lines. Check for similar patterns in the codebase. Consider using #pragma warning(push) and #pragma warning(disable: 4499) to suppress the warning for those template specializations. Verify that the fix compiles without errors on Windows with /std:c++latest.