chakra-core/ChakraCore

don't emit LdNativeCodeData if function doesn't use any

Open

#5,516 opened on Jul 24, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import
Performancehelp wanted

Description

Most JS functions will have a bailout or something that uses native code data, but wasm functions never will (or almost never). We should change to only emit this instruction only if we actually need it. It's a bit tricky to track, since most of the uses are introduced during lowerer or later, but it should be doable.

Contributor guide

Tech stack
cppjavascript
Domain
performance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++JavaScript engine internalscompiler optimization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
Investigate how and where LdNativeCodeData instructions are emitted in the ChakraCore backend. Track all uses introduced during lowering and later phases, and implement a conditional emit mechanism. The issue is open and unassigned, so no linked PRs or comments. Focus on the backend code in the JIT compiler, likely in files related to code generation.