chakra-core/ChakraCore

JSRT: JsDeleteIndexedProperty does not tell successful or not

Open

#504 opened on Mar 10, 2016

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import
APIsBugSeverity: 3good first issuehelp wanted

Description

JsDeleteIndexedProperty API does not tell if the deletion is successful or not, unlike JsDeleteProperty which returns that info in "result". The former also misses "useStrictRules" flag which exists in the later.

JsDeleteIndexedProperty(JsValueRef object, JsValueRef index)

JsDeleteProperty(JsValueRef object, JsPropertyIdRef propertyId,
                 bool useStrictRules,
                 JsValueRef *result)

These 2 APIs should be comparable and consistent.

Contributor guide

Tech stack
cjavascript
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C programmingChakraCore API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the implementation of JsDeleteIndexedProperty and JsDeleteProperty in the ChakraCore source, likely in jsrt.cpp. The goal is to add a 'result' parameter and 'useStrictRules' flag to JsDeleteIndexedProperty, and update its call sites to return success status. Check existing tests for the delete property API to understand expected behavior.