chakra-core/ChakraCore

Remove asm.js templatized jit from release builds

Open

#3,757 opened on Sep 18, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import
Taskhelp wanted

Description

We aren't turning this on any time soon, so we shouldn't unnecessarily bloat the binary with it.

Contributor guide

Tech stack
javascriptcpp
Domain
backendperformance
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ knowledgeBuild system experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the ChakraCore build configuration files (e.g., Makefile, CMakeLists.txt) to locate where asm.js templatized JIT code is included. Remove the relevant source files or conditional compilation flags. Ensure that release builds do not include this feature. Test that non release builds still work if needed. Refer to any existing comments in the source for context.
Remove asm.js templatized jit from release builds · chakra-core/ChakraCore#3757 | Good First Issue