chakra-core/ChakraCore

[linux] Re-enable static valid pointer maps

Open

#343 opened on Feb 18, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import
Linuxhelp wanted

Description

Static valid pointer maps for the Recycler are disabled on Linux builds. This is because the maps (under lib\Common\Memory\ValidPointerMap) generated don't currently compile with clang. The generation code (GenerateValidPointersMap) in HeapInfo.cpp needs to be updated to generate cross-platform VPMs, after which we can re-enable the feature.

Contributor guide

Tech stack
cppc
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++Compiler compatibilityChakraCore Recycler
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the files under lib/Common/Memory/ValidPointerMap to understand the current static valid pointer maps. Examine HeapInfo.cpp's GenerateValidPointersMap function to identify what prevents clang compilation. The goal is to update the generation code to produce cross platform VPMs, then re enable the feature for Linux builds.
[linux] Re-enable static valid pointer maps · chakra-core/ChakraCore#343 | Good First Issue