chakra-core/ChakraCore

Test: split non-timezone-specific tests to their own test files

Open

#2,869 opened on Apr 24, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import
TaskTest Bughelp wanted

Description

See: https://github.com/Microsoft/ChakraCore/issues/319

This will allow us to increase test coverage in cases that are not fundamentally broken while waiting for additional features like spoofing timezone for the ch process.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with ChakraCore test structurebasic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Locate the existing test files that contain timezone specific tests (possibly in a single file). Create new separate test files for non timezone specific tests, copying relevant tests and ensuring they pass without timezone mocking. Reference issue #319 for the original discussion and motivation.