chakra-core/ChakraCore

Use /Zc:strictStrings flag in VC builds.

Open

#1,942 opened on Nov 8, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import
Codebase QualityContinuous IntegrationSuggestiongood first issuehelp wanted

Description

Proposed in #1802

Contributor guide

Tech stack
cpp
Domain
build system
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ knowledgeWindows build environmentVisual Studio
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue proposes enabling the /Zc:strictStrings compiler flag in Visual C++ builds. To implement, you need to locate the build configuration files (e.g., .vcxproj or CMakeLists.txt) and add the flag. Review issue #1802 for context. After adding the flag, ensure the codebase compiles without warnings or errors. No existing PRs or assignees, but the issue is old; check if it has been superseded.