cevoaustralia/aws-google-auth

PyPI tarball doesn't include tests data files

Open

#120 opened on Dec 1, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (531 stars) (172 forks)batch import
enhancementhelp wanted

Description

The released PyPI tarball doesn't include the following test data files, required for the tests:

  • tests/saml-response-expired-before-valid.xml
  • tests/saml-response-too-late.xml
  • tests/saml-response-too-soon.xml
  • tests/valid-response.xml
...

======================================================================
ERROR: test_invalid_saml_expired_before_valid (aws_google_auth.tests.test_amazon.TestAmazon)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 61, in test_invalid_saml_expired_before_valid
    saml_xml = self.read_local_file('saml-response-expired-before-valid.xml')
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 24, in read_local_file
    with open(path.join(here, filename)) as fp:
IOError: [Errno 2] No such file or directory: '/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/saml-response-expired-before-valid.xml'

======================================================================
ERROR: test_invalid_saml_too_late (aws_google_auth.tests.test_amazon.TestAmazon)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 57, in test_invalid_saml_too_late
    saml_xml = self.read_local_file('saml-response-too-late.xml')
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 24, in read_local_file
    with open(path.join(here, filename)) as fp:
IOError: [Errno 2] No such file or directory: '/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/saml-response-too-late.xml'

======================================================================
ERROR: test_invalid_saml_too_soon (aws_google_auth.tests.test_amazon.TestAmazon)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 53, in test_invalid_saml_too_soon
    saml_xml = self.read_local_file('saml-response-too-soon.xml')
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 24, in read_local_file
    with open(path.join(here, filename)) as fp:
IOError: [Errno 2] No such file or directory: '/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/saml-response-too-soon.xml'

======================================================================
ERROR: test_role_extraction (aws_google_auth.tests.test_amazon.TestAmazon)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 32, in test_role_extraction
    saml_xml = self.read_local_file('valid-response.xml')
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 24, in read_local_file
    with open(path.join(here, filename)) as fp:
IOError: [Errno 2] No such file or directory: '/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/valid-response.xml'

======================================================================
ERROR: test_role_extraction_too_many_commas (aws_google_auth.tests.test_amazon.TestAmazon)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 43, in test_role_extraction_too_many_commas
    saml_xml = self.read_local_file('too-many-commas.xml')
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 24, in read_local_file
    with open(pa
th.join(here, filename)) as fp:
IOError: [Errno 2] No such file or directory: '/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/too-many-commas.xml'

======================================================================
ERROR: test_valid_saml (aws_google_auth.tests.test_amazon.TestAmazon)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 72, in test_valid_saml
    saml_xml = self.read_local_file('saml-response-no-expire.xml')
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_amazon.py", line 24, in read_local_file
    with open(path.join(here, filename)) as fp:
IOError: [Errno 2] No such file or directory: '/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/saml-response-no-expire.xml'

======================================================================
ERROR: test_extra_step (aws_google_auth.tests.test_google.TestGoogle)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_google.py", line 18, in test_extra_step
    response = self.read_local_file('google_error.html')
  File "/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/test_google.py", line 14, in read_local_file
    with open(path.join(here, filename), encoding='utf8') as fp:
IOError: [Errno 2] No such file or directory: '/tmp/nix-build-aws-google-auth-0.0.29.drv-0/aws-google-auth-0.0.29/aws_google_auth/tests/google_error.html'

----------------------------------------------------------------------
Ran 96 tests in 2.664s

FAILED (errors=7)
Test failed: <unittest.runner.TextTestResult run=96 errors=7 failures=0>

Contributor guide

Tech stack
python
Domain
testingbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of Python packagingFamiliarity with MANIFEST.in or setup.py
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is that the released PyPI tarball does not include test data files required for tests. To fix this, the missing XML files (saml response expired before valid.xml, saml response too late.xml, saml response too soon.xml, valid response.xml, too many commas.xml, saml response no expire.xml, google error.html) need to be included in the distribution. This can be done by adding these files to MANIFEST.in or by specifying them as package data in setup.py. Look at the current setup.py or MANIFEST.in in the repository to see how other data files are included. No linked PRs or comments suggest a solution yet.