cefsharp/CefSharp

WinForms Example - Find not correctly selecting next match.

Open

#4,542 opened on Jul 4, 2023

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C# (10,221 stars) (2,940 forks)batch import
Help Wantedup-for-grabswinforms

Description

Is there an existing issue for this?

  • I have searched both open/closed issues, no issue already exists.

CefSharp Version

113.1.4

Operating System

Windows 11

Architecture

x86

.Net Version

4.8

Implementation

WinForms

Reproduction Steps

  • Open any PDF file in the browser with "file:///"
  • In the WinForms.Example application click on Edit->Find
  • Enter text in the TextBox and hit Enter --> Find(...) method will be executed and found results are marked in the scroll bar at the side --> Matching text will not be highlighted and "Find Next", "Find Previous" buttons won't do anything visible to the user (they also do not seem to do from HTML pages)

Expected behavior

Matching content is highlighted (like it is for HTML documents) and the browser scrolls to make the match visible, if not currently visible.

Actual behavior

Matches are only indicated in the scroll bar but no highlighting is visible.

Regression?

No response

Known Workarounds

No response

Does this problem also occur in the CEF Sample Application

No

Other information

Not sure if it is a CefSharp or a CEF issue. The CEF sample application behaves a bit better, but has a different search dialog compared to the WinForms Example that comes with CefSharp.

Contributor guide

Tech stack
csharp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
C#WinFormsCefSharp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the Find method implementation in the CefSharp WinForms example, specifically in the CefSharp.WinForms.Example project. Compare the behavior with the CEF sample application to determine if the bug is in CefSharp's search handling or CEF itself. Look at the FindDialog class and how it interacts with the browser's Find method. Check if the issue is related to how search results are highlighted or how the browser scrolls to matches.