catchorg/Catch2

Incorrect trap code for iOS fails compilation

Open

#1,870 opened on Feb 19, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (3,228 forks)batch import
BugHelp wanted

Repository metrics

Stars
 (20,381 stars)
PR merge metrics
 (Avg merge 4d 16h) (2 merged PRs in 30d)

Description

Describe the bug v2.11.1 introduced support for breaking into the debugger on iOS and while it works with XCode 10 and 11, it fails with 8 and 9.

You can reproduce the issue by cloning sjson-cpp at this branch. Make sure to clone submodules as Catch2 is used as a submodule.

python make.py -clean -build -compiler ios -config Debug

The issue also happens with Release config. See here for example build output.

Expected behavior I know that these are older xcode versions but I am wondering if we could support them as 2.11.0 worked fine previously.

Reproduction steps Simply compiling Catch2 v2.11.1 on XCode 8 or 9 will fail.

Platform information:

  • OS: OS X 10.13.6
  • Compiler+version: Apple LLVM version 9.1.0 (clang-902.0.39.2)
  • Catch version: v2.11.1

Additional context

Contributor guide

Research direction
Investigate the trap code introduced in PR #1817. Check for compiler version checks (e.g., clang major ) and ensure compatibility with Xcode 8/9 (clang based on LLVM 9.1.0). The failing code is likely in a platform specific debugger support file such as catch debugger.hpp. Consider adding conditional compilation for older clang versions.
Tech stack
cpp
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++preprocessor macros
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40