casesandberg/react-color

Propogate view from toggle button on ChromePicker

Open

#584 opened on Feb 5, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (11,679 stars) (946 forks)batch import
enhancementhelp wanted

Description

The current view state of the ChromeFields input in ChromePicker is not externally accessible and makes it difficult to tie in with other components.

I suggest adding an onToggleView callback to pass the new "view" state as a parameter back up to its container. e.g: if(this.props.onToggleView){ this.props.onToggleView('hex'); }

Contributor guide

Tech stack
react
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React basicsreact color API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue requests adding an onToggleView callback to ChromePicker to pass the view state (e.g., 'hex') to the container. The change is localized to the ChromePicker component. Look at the existing props and how other callbacks like onChange are implemented. Examine the ChromeFields input to determine where the view state is toggled. Add a prop and invoke it with the new view value when the toggle button is clicked. No linked PRs or maintainer comments addressing this request.