casesandberg/react-color

Cant type in 4 or 8 letter color names in editable input anymore

Open

#552 opened on Oct 19, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (946 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,679 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

On the react color demo page I am able to type in "blue" into any of the editable inputs and that is recognized as valid. Since this fix - https://github.com/casesandberg/react-color/commit/669bf040955d2b8ff82b491e1044d28fe80d06b5#diff-012ff5a8f8316a2507102ec918eaf81b I am not able to type in 4 or 8 letter color names. They return as invalid because of the length check. So while "red" or "yellow" works fine, "blue" or "gray" doesnt.

Is there a work around for this?

Contributor guide

Research direction
Examine the commit 669bf040955d2b8ff82b491e1044d28fe80d06b5 and the relevant code to modify the validation to allow 3, 4, 6, and 8 character color names.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75