casesandberg/react-color

Cant type in 4 or 8 letter color names in editable input anymore

Open

#552 opened on Oct 19, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (11,679 stars) (946 forks)batch import
bughelp wanted

Description

On the react color demo page I am able to type in "blue" into any of the editable inputs and that is recognized as valid. Since this fix - https://github.com/casesandberg/react-color/commit/669bf040955d2b8ff82b491e1044d28fe80d06b5#diff-012ff5a8f8316a2507102ec918eaf81b I am not able to type in 4 or 8 letter color names. They return as invalid because of the length check. So while "red" or "yellow" works fine, "blue" or "gray" doesnt.

Is there a work around for this?

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Reactbasic string validation logic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is caused by a commit that added a length check for color names. Examine the commit at https://github.com/casesandberg/react color/commit/669bf040955d2b8ff82b491e1044d28fe80d06b5 and locate the helper function that validates color names (likely in src/helpers/). The current check rejects names with lengths other than 3, 5, 6, or 7, but should allow any length (e.g., 4 for 'blue', 8 for 'gray'). To fix, remove or modify the length validation to accept all valid CSS color names. No existing PR or assignee, so it's open for contribution.