casesandberg/react-color

2.14.0 Block colorpicker transparent swatch doesn't trigger onChange

Open

#500 opened on Apr 12, 2018

View on GitHub
 (5 comments) (2 reactions) (0 assignees)JavaScript (946 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,679 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

<BlockPicker                                                                                    
  color="#ffffff"                                                                               
  colors={['#FF0000','transparent']}                              
  onChangeComplete={ handleColorChange }                                                        
  onChange={ handleColorChange }                                                                
/>

Will never trigger handleColorChange on click of the 'transparent' swatch. Works correct in 2.13

Contributor guide

Research direction
Examine the BlockPicker component source code in version 2.14.0, focusing on the `onChange` handler for swatch clicks. Compare with version 2.13 to identify what changed regarding the handling of transparent color values. Check if the transparent color is being passed correctly to the onChange callback or if it's being filtered out.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitnpmReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75