casesandberg/react-color

2.14.0 Block colorpicker transparent swatch doesn't trigger onChange

Open

#500 opened on Apr 12, 2018

View on GitHub
 (5 comments) (2 reactions) (0 assignees)JavaScript (11,679 stars) (946 forks)batch import
bughelp wanted

Description

<BlockPicker                                                                                    
  color="#ffffff"                                                                               
  colors={['#FF0000','transparent']}                              
  onChangeComplete={ handleColorChange }                                                        
  onChange={ handleColorChange }                                                                
/>

Will never trigger handleColorChange on click of the 'transparent' swatch. Works correct in 2.13

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScriptUnderstanding of onChange events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the BlockPicker component in the react color repository. Compare the code between versions 2.13 and 2.14 to identify what changed regarding the 'transparent' swatch selection. Look at the BlockPicker's onChange handling to see if 'transparent' value is properly dispatched. Check the rendered output to ensure the swatch click event is correctly bound.