casesandberg/react-color

Photoshop HSV up/down arrow controls are not working correctly

Open

#385 opened on Jul 23, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (11,679 stars) (946 forks)batch import
help wanted

Description

When using arrow up/down keys on the (S)aturation field, the Value fields jumps to 0. After this, losing focus of the Saturation field will have it jump back to 0 too, because the Value is 0 and the actual color value updates the color picker. You can see the docs page to confirm this.

Contributor guide

Tech stack
javascriptreacthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Reactfamiliarity with color models
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the Photoshop color picker component in `src/components/photoshop/Photoshop.js`. The bug is related to HSV input fields. Look at how the `Saturation` and `Value` fields interact with keyboard events. The issue reports that using arrow up/down on Saturation causes Value to jump to 0 and losing focus reverts it. Consider adding proper state updates and validation to prevent the Value from being incorrectly set to 0 when Saturation changes. There are no linked PRs or comments, so the fix is open. Ensure that the color conversion functions in `src/helpers/color.js` are correctly used.