casesandberg/react-color

RTL support

Open

#359 opened on Jun 14, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (11,679 stars) (946 forks)batch import
enhancementhelp wanted

Description

Is there any planning for supporting strings wi RTL direction inside build in pickers? Update: Putting direction: rtl on page will effect pickers (They won't look good), So may be enforce direction ltr on all pickers?

Contributor guide

Tech stack
reactcss
Domain
frontendinternationalization
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
This issue requests RTL support for the color pickers. The current suggestion is to enforce LTR direction on all pickers. Investigate the CSS of components in the repository to see how direction is handled. A possible approach is to add a prop to toggle direction or apply a global class. Look at the existing codebase for any direction related styling and consider how to integrate RTL support without breaking existing layouts. Check for any existing discussions in the comments for further context.