casesandberg/react-color

SliderPicker Dynamic Brightness

Open

#28 opened on Aug 19, 2015

View on GitHub
 (5 comments) (1 reaction) (0 assignees)JavaScript (946 forks)batch import
help wanted

Repository metrics

Stars
 (11,679 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When passing a hex value through the color prop on the 'slider' ColorPicker, the color value is set properly (from what I can tell) on the hue slider, but the 5 swatches themselves are all different.

My expectation would be that the center swatch is auto-selected with the exact color value passed to it, as those are generally used as the visual cue for 'This is the color that is selected'.

Not a bug so much as just unexpected output? :)

Contributor guide

Research direction
Inspect the SliderPicker component and its Swatches child to understand how the color prop is processed. Check if the center swatch is correctly set to the exact hex value passed, and trace any color calculations that might alter the displayed swatch colors.
Tech stack
reactjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70