casesandberg/react-color

SliderPicker Dynamic Brightness

Open

#28 opened on Aug 19, 2015

View on GitHub
 (5 comments) (1 reaction) (0 assignees)JavaScript (11,679 stars) (946 forks)batch import
help wanted

Description

When passing a hex value through the color prop on the 'slider' ColorPicker, the color value is set properly (from what I can tell) on the hue slider, but the 5 swatches themselves are all different.

My expectation would be that the center swatch is auto-selected with the exact color value passed to it, as those are generally used as the visual cue for 'This is the color that is selected'.

Not a bug so much as just unexpected output? :)

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React basicsunderstanding of color hex values
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the SliderPicker component in the react color repository, particularly how the `color` prop is used to set the swatch colors. The issue suggests that the center swatch should display the passed hex value but currently shows different colors. Look at the component's logic for generating the 5 swatches and ensure the center swatch reflects the selected color. Check the related comments or any linked PRs for known behavior.