Running SSHKit tests with Rake 11.0 reveals many Ruby warnings
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
Research direction
Start by running SSHKit's test suite with Rake 11.0 and Ruby warnings enabled, then inspect the warning locations named in lib/sshkit/runners/group.rb, lib/sshkit/host.rb, and lib/sshkit/backends/abstract.rb. Review the existing discussion before choosing whether the warnings should be fixed or suppressed; done means the project has a decided approach and the warning flood is addressed.
Written by the indexing model from the issue text.
Description
Rake 11.0 turns on Ruby warnings by default. With warnings enabled, running SSHKit's test suite results in a flood of messages like this:
lib/sshkit/runners/group.rb:15: warning: instance variable @group_size not initialized
lib/sshkit/host.rb:59: warning: instance variable @local not initialized
lib/sshkit/backends/abstract.rb:141: warning: instance variable @pwd not initialized
lib/sshkit/backends/abstract.rb:149: warning: instance variable @env not initialized
lib/sshkit/backends/abstract.rb:149: warning: instance variable @user not initialized
lib/sshkit/backends/abstract.rb:149: warning: instance variable @group not initialized
We could:
- Treat these warnings as legitimate and try to fix them; or
- Turn off Ruby warnings
I haven't had time to think this through yet, so for now I'm just opening it for discussion.
Your thoughts?
- Dominant language
- Ruby
- Stars
- 1.2k
- Forks
- 257
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from capistrano/sshkit
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
capistrano/sshkit#563 · 6 reactions ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
capistrano/sshkit#562 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
capistrano/sshkit#554 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
capistrano/sshkit#543 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
capistrano/sshkit#518 · 1 comment ·
All issues in capistrano/sshkit
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
TheOdinProject/curriculum#31423 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
oxidize-rb/rb-sys#807 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
ai-generated
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100