canton7/SyncTrayzor

Updating portable installation requires write access to the parent directoty

Open

#368 opened on May 22, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (5,477 stars) (390 forks)batch import
help wanted

Description

Update process for "portable" installations in its current form creates a temporary copy of itself outside of the actual installation folder, which requires additional access rights.

Example: if the portable installation folder resides in the root of a hard drive, it'll always fail.

Modifications outside the installation folder should be avoided in general, especially so for portable installation.

SyncTrayzor v.1.1.16 Windows 10 x64

Contributor guide

Tech stack
csharp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Windows file permissions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the update mechanism for portable installations. Look at how the application creates temporary copies during update, likely using `Path.GetTempPath()` or similar. The fix should ensure that all temporary files are created within the installation folder. Check the main update logic in the codebase, possibly in files related to update or portable mode. Consider using `AppDomain.CurrentDomain.BaseDirectory` to determine the installation folder.