canton7/SyncTrayzor

Horizontal scroll bug in conflict editor

Open

#363 opened on May 14, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (5,477 stars) (390 forks)batch import
bughelp wanted

Description

There's a bug in the conflict editor in the pane where you choose which version of a conflict to accept. The horizontal scroll bar only scrolls the second entry, not the first one.

When running SyncTrayzor on a tablet device (for example), this makes it impossible to accept the first version in a conflict for long filenames, as the button is off-screen in an un-scrollable region.

SyncTrayzor: 1.1.15 SyncThing: 0.14.27

Contributor guide

Tech stack
csharp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#WPF
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the conflict editor pane in the SyncTrayzor source code. Look for the XAML or code behind file responsible for the list or scroll viewer that contains the two versions. The bug suggests that the first version's container does not have a horizontal scrollbar, while the second does. Check the data templates or control definitions for the conflict resolution view.