canonical/multipass

[sshfs] Multipass logs leaking filepaths from CI environments

Open

#4,195 opened on Jun 30, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (6,956 stars) (634 forks)batch import
buggood first issuelow

Description

In several compilation units, we are using the __FILE__ macro in logging messages. This is causing Multipass to leak file paths from our CI environment. i.e. [trace] [ssh process] /Users/cibot/actions-runner-2/_work/multipass-private/multipass-private/src/ssh/ssh_process.cpp:167 read_stream(type = 0, timeout = -1).

We should not be printing out the full path for the file. This part of the log message should either be removed or truncated to only include the top level src/ directory.

Contributor guide

Tech stack
cpp
Domain
security
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic C++ knowledgeUnderstanding of FILE macro
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is to remove or truncate file paths leaked by the FILE macro in logging statements across several compilation units in the Multipass source code. The fix involves modifying log messages to either omit the full path or only include the relative path from the src/ directory. Contributors should locate all usages of FILE in the src/ directory and adjust them accordingly. No linked PRs or assignees, so the issue is open for contribution.