canonical/multipass

Fix spinner for non-interactive use

Open

#1,541 opened on May 15, 2020

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (634 forks)batch import
enhancementhelp wantedlow hanging fruitmedium

Repository metrics

Stars
 (6,956 stars)
PR merge metrics
 (Avg merge 16d 2h) (50 merged PRs in 30d)

Description

Attempting to run non-interactive scripts that run multipass. Logs look like this:

Creating VMs...

                                                                                

                                                                                
Creating test-0  / 
                                                                                

                                                                                
Configuring test-0  /- 
                                                                                

                                                                                
Starting test-0  /-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\ 
                                                                                

                                                                                
Waiting for initialization to complete  /-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\| 
                                                                                
Launched: test-0

                                                                                
Created VM test-0.

This could be resolved by disabling spinners when not running on a live terminal, or via switch.

Contributor guide

Research direction
Implement a check for interactive terminal (isatty) to disable spinner animation when output is not a live terminal.
Tech stack
cpp
Domain
backendcli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75