canonical/multipass

Characters not escaped in commands

Open

#1,495 opened on Apr 17, 2020

View on GitHub
 (14 comments) (0 reactions) (1 assignee)C++ (634 forks)batch import
bughelp wantedmedium

Repository metrics

Stars
 (6,956 stars)
PR merge metrics
 (Avg merge 16d 2h) (50 merged PRs in 30d)

Description

$ multipass mount . primary:~/path/with\$dollarsign
$ multipass exec primary -- ls path/with\$dollarsign
ls: cannot access 'path/with$dollarsign': No such file or directory
$ multipass exec primary -- ls path/with
Dokumenty   Muzyka   Obrazy   Pobrane   Publiczny   Pulpit   Szablony   Wideo

Originally posted by @Saviq in https://github.com/canonical/multipass/pull/1439#pullrequestreview-395244787

Contributor guide

Research direction
Inspect how the command string is constructed in the Multipass codebase, particularly where shell commands are built, and ensure special characters like $ are properly escaped.
Tech stack
None
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70