Something is definitely wrong with <ThemeProvider>'s typings 👀
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 25/100
Research direction
Start with the linked CodeSandbox reproduction and inspect the ThemeProvider typings and usage shown there. Confirm which typing behavior is incorrect and define the expected ThemeProvider usage before changing anything; the issue is done when the reproduction no longer reports the typing problem.
Written by the indexing model from the issue text.
Description
Description
BTW i don't really understand what for this component is needed
Everything seems to work fine even without it
withTheme() HOC kinda provides theming 🤷🏼♂️
Reproducible Demo
I've reproduced this issue on CodeSandbox
Come check that out 👇
- Dominant language
- JavaScript
- Stars
- 466
- Forks
- 53
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from callstack/react-theme-provider
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
question
Difficulty 5/5 Over a week Newbie friendliness 10/100
callstack/react-theme-provider#156 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
callstack/react-theme-provider#144 · 3 comments · 4 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
callstack/react-theme-provider#130 · 2 comments · 1 reaction ·
All issues in callstack/react-theme-provider
Similar issues
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
apache/cloudstack#14222 ·
-
Browser Waiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
getsentry/sentry-javascript#24577 · 1 comment ·
-
curation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
amponce/archive-movie-browser#186 ·
-
light
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
aemdemos/patients-stryker#253 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
clerk/javascript#9852 ·