cake-build/cake

CleanDirectories does not handle cleaning directories with symlinks without unnecessary errors

Open

#2,135 opened on Apr 23, 2018

View on GitHub
 (1 comment) (2 reactions) (0 assignees)C# (3,742 stars) (738 forks)batch import
BugHelp wantedUp-for-grabs

Description

What You Are Seeing?

This error

An error occurred when executing task 'Default'.
Error: One or more errors occurred.
	Could not find a part of the path '/Users/donblas/tmp/cake/example/fsharp-macos.framework/Versions/Current'.

when cleaning directories of a certain structure.

What is Expected?

It to clean without error.

What version of Cake are you using?

$ mono .cake/Cake/Cake.exe --version | tail -n 2 Version 0.27.1+Branch.main.Sha.7e44aa0319b6ef12ecc415d79a1c75cc98e2c788

Are you running on a 32 or 64 bit system?

64-bit

What environment are you running on? Windows? Linux? Mac?

macOS

Are you running on a CI Server? If so, which one?

Reproduces without.

How Did You Get This To Happen? (Steps to Reproduce)

clean_bug.zip

  1. Download attached zip file
  2. Copy fsharp-macos.framework from the backup folder to example
  3. ./build.sh

Output Log

Diag: https://gist.github.com/chamons/3def1b016716b71beb2365a322ba2513 Diag w\ mono: https://gist.github.com/chamons/858cdcca2266a6afb796fa4ba4a108fa --verbosity diagnostic -mono -Experimental: https://gist.github.com/chamons/b9248c9d30c167c679fd4b3b3d56f81a

Contributor guide

Tech stack
csharp
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of C#Understanding of symlinks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the CleanDirectories implementation in the Cake build system (likely in src/Cake.Core/IO/DirectoryCleaner.cs or similar). The issue is that cleaning a directory containing symlinks (e.g., a macOS framework) throws a 'Could not find a part of the path' error. The fix should ensure that symlinks are properly followed or skipped during directory traversal. Start by reproducing the bug with the provided zip file, then examine how Directory.Delete handles symlinks on macOS. A possible solution is to use Directory.EnumerateFileSystemEntries with appropriate options or handle the case where a symlink target does not exist by skipping it.