cake-build/cake

CopyFiles does not respect folder structure when pattern only matches files in a subdirectory

Open

#2,102 opened on Mar 26, 2018

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C# (3,742 stars) (738 forks)batch import
BugHelp wantedUp-for-grabs

Description

What You Are Seeing?

CopyFiles does not correctly respect the folder structure when a pattern is used which only matches files in a subdirectory.

What is Expected?

If I have the files: ./src/file1.txt ./src/sub/file2.txt ./src/sub/file3.dat

The command CopyFiles("./src/**/*.txt", "./dest", true) will result in: ./dest/file1.txt ./dest/sub/file2.txt

However the command CopyFiles("./src/**/*.dat", "./dest", true) will result in: ./dest/file3.dat

I would expect it to result in: ./dest/sub/file3.dat

What version of Cake are you using?

0.26.1

Are you running on a 32 or 64 bit system?

64bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

No

How Did You Get This To Happen? (Steps to Reproduce)

This repo demonstrates the issue: https://github.com/dandezille/cake-copyfiles

Output Log

https://gist.github.com/dandezille/f34f8f0c0fc8429be8fe85397c588856

Contributor guide

Tech stack
csharp
Domain
build systemtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsCake build system basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The bug is in the CopyFiles method. The issue provides a minimal repo (https://github.com/dandezille/cake copyfiles) to reproduce the problem. Examine the implementation of CopyFiles in the Cake source code, specifically how directory structure is preserved when the pattern only matches files in subdirectories. The expected behavior is that the directory hierarchy relative to the source should be maintained in the destination. Check if the issue is in the pattern matching or directory creation logic. Look at existing tests for CopyFiles to understand expected behavior.