cake-build/cake

DotNetCorePublish OutputDirectory is not relative to WorkingDirectory

Open

#1,917 opened on Nov 14, 2017

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C# (3,742 stars) (738 forks)batch import
Help wantedImprovementUp-for-grabs

Description

DotNetCorePublishSettings has a property WorkingDirectory which I set to my project dir relative to repository root (where my cake.build file is). eg, ./source/MyProject. There is also a property OutputDirectory which I set to ./obj/Docker/publish.

Now I would assume, that output directory would be relative to working dir, but it's not - it is relative to cake.build file (aka repository root).

Contributor guide

Tech stack
csharp
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Cake build systemBasic understanding of C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate DotNetCorePublishSettings to understand how WorkingDirectory and OutputDirectory are resolved. The issue states OutputDirectory should be relative to WorkingDirectory but it's relative to the repository root. Check the code in the Cake repository, likely in the DotNetCorePublish alias or settings class. Look for any existing tests or PRs. Provide a fix that makes OutputDirectory relative to WorkingDirectory when specified.