bytedeco/javacpp

Generalize automatic addition of adapter annotations

Open

#670 opened on Apr 8, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Java (620 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,279 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It would be nice to generalize this logic for, eg, containers or arrays. Currently, if we must map a std::vector<std::shared_ptr<M>>, we need to add an info new Info("std::shared_ptr<M>").pointerTypes("M"). While this is not needed if std::shared_ptr<M> is the type of a function argument or a return type. But adding such manual info also cancel the automatic additions of @Cast and possibly others performed by the parser.

Could this logic be moved from declarator() to type() ?

Contributor guide

Research direction
Inspect the logic in Parser.java lines 1367-1420 and evaluate moving it from declarator() to type() to generalize adapter annotations for containers and arrays.
Tech stack
java
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40