bytedeco/javacpp

Space in directory name and read only during build

Open

#433 opened on Oct 29, 2020

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Java (4,279 stars) (620 forks)batch import
bughelp wantedquestion

Description

Trying to use this, I hit a problem where if your jar is located in a path with a space in the name (on Windows at least), it would throw an error: java.net.URISyntaxException: Illegal character in opaque part at index This is because of Loader.java, around here (line 1551 in latest):

for (URL url : urls) { URI uri = url.toURI();

Locally I worked around this by changing it to:

for (URL url : urls) { String tUrl = url.toString().replace(" ","%20"); URI uri = new URI(tUrl);

I'm sure there are more elegant solutions but this got me going again.

Also, during the build process, I had some DLLs which were read only. This caused the build to crash when it was copying the various DLLs (line 1219). Changed it to simply make the file writeable before copying in:

// make sure it isn't read only if (fo.exists()) { fo.setWritable(true); }

One last thing -- a few line blurb on the front-page on how to build it would be nice (I'm not a maven god by any means but I was able to figure it out so it isn't hard but one sentence with an example command line would be nice)

Contributor guide

Tech stack
javacpp
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaMaven
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue identifies two bugs: 1) In Loader.java (line 1551), URL encoding for spaces must be handled when converting URL to URI. A simple fix is to replace spaces with '%20' in the URL string before creating the URI. 2) In the build process (line 1219), files should be made writable before copying to avoid read only failures. The fix is to call setWritable(true) on existing files. Additionally, the issue requests adding build instructions to the README. The code changes are localized and have been tested by the reporter.