bytedeco/javacpp

Attach as Daemon

Open

#236 opened on May 2, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Java (4,279 stars) (620 forks)batch import
help wantedquestion

Description

I'd like for the JNI code to attach as a daemon thread. This will allow my applications to cleanly exit when using the hack provided #143. It will also be useful when I finish my bindings for Decklink, which will likely be function pointer based. Does anyone foresee an issue with doing this? I'd be happy to put up a pull request and test it with my build of FFmpeg later this week.

See this line in the generator.

Contributor guide

Tech stack
javacpp
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of JNI thread attachmentJava and C++ basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the JNI generator around line 1160 in Generator.java. The change involves replacing AttachCurrentThread with AttachCurrentThreadAsDaemon. Ensure the code still compiles and works with FFmpeg bindings. Review any linked PRs or comments for additional context.