net feature alone fails to compile in 1.1.5: sockopt uses crate::timespec, which net does not gate in
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- backend, networking
Research direction
The issue is in src/lib.rs where the timespec module is gated. Look at lines 389-409 to see the cfg list. Add 'net' to that list. Then verify the fix by running cargo check with the failing feature set: --no-default-features --features std,net. Also check the sockopt.rs files in both backend directories to confirm they reference crate::timespec.
Written by the indexing model from the issue text.
Description
Enabling only net (with default-features = false) fails to compile. Both backends' sockopt modules reference crate::timespec unconditionally, but mod timespec is gated on a feature list that does not include net.
This affects consumers that opt into a minimal API surface rather than taking default features. In our case a crate depends on rustix purely for socket primitives and sets default-features = false, features = ["std", "net"] deliberately, so that the fs, process, thread and event APIs are not compiled in.
The configuration built cleanly on 1.1.4 and regressed in 1.1.5.
Reproduction
[dependencies]
rustix = { version = "=1.1.5", default-features = false, features = ["std", "net"] }
$ cargo build
error[E0433]: cannot find `timespec` in `crate`
--> rustix-1.1.5/src/backend/linux_raw/net/sockopt.rs:293:39
|
293 | .unwrap_or(crate::timespec::Secs::MAX),
| ^^^^^^^^ could not find `timespec` in the crate root
|
note: found an item that was configured out
--> rustix-1.1.5/src/lib.rs:410:5
|
410 | mod timespec;
| ^^^^^^^^
error: could not compile `rustix` (lib) due to 6 previous errors
Equivalently, from a checkout of v1.1.5:
$ cargo check --no-default-features --features std,net
6 x error[E0433]: cannot find `timespec` in `crate`
$ cargo check --no-default-features --features std,net,use-libc
3 x error[E0433]: cannot find `timespec` in `crate`
The error count differs by backend because backend/linux_raw/net/sockopt.rs has six references to crate::timespec and backend/libc/net/sockopt.rs has three.
Platform / versions
- rustix 1.1.5 (1.1.4 is unaffected)
- rustc 1.98.1, x86_64-unknown-linux-gnu; also reproduced on CI for aarch64-apple-darwin
- Both backends: linux_raw (default) and libc (
use-libc) mainat 287214b889865d8e1406a0ee71cc409b6f6191c8 is the 1.1.5 release commit and carries the same gate, so the issue is present onmainas well
Cause
src/lib.rs:389-409 gates the module:
#[cfg(any(
feature = "fs",
feature = "event",
feature = "process",
feature = "runtime",
feature = "thread",
feature = "time",
...
))]
mod timespec;
net is absent from that list, while SO_RCVTIMEO / SO_SNDTIMEO handling in both backends' sockopt.rs uses crate::timespec::Timespec and crate::timespec::Secs with no corresponding cfg.
Suggested fix
Add net to the gate, since the net API genuinely needs the module:
#[cfg(any(
feature = "fs",
feature = "event",
+ feature = "net",
feature = "process",
feature = "runtime",
feature = "thread",
feature = "time",
src/timespec.rs depends only on core, crate::backend::c and crate::ffi, so this does not pull in any further feature-gated code.
With that one line applied to v1.1.5, the following all pass on rustc 1.98.1:
--no-default-features --features std,net PASS (was 6 errors)
--no-default-features --features std,net,use-libc PASS (was 3 errors)
--no-default-features --features std PASS
--no-default-features --features std,fs PASS
--no-default-features --features all-apis PASS
--no-default-features --features all-apis,use-libc PASS
Gating the sockopt timeout code instead would also compile, but it would silently drop SO_RCVTIMEO / SO_SNDTIMEO support from a net-only build, which seems worse than compiling the module.
I am happy to open a PR with the one-line change if that is the preferred fix.
- Dominant language
- Rust
- Stars
- 2.1k
- Forks
- 298
- Avg merge
- 9d 3h
- Merged PRs (30d)
- 3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bytecodealliance/rustix
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
bytecodealliance/rustix#1660 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
bytecodealliance/rustix#1635 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
bytecodealliance/rustix#1068 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
bytecodealliance/rustix#1686 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 74/100
bytecodealliance/rustix#1685 ·
All issues in bytecodealliance/rustix
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
state:needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
zed-industries/zed#64680 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
RustPython/RustPython#8802 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
TheLarkInn/aipm#2390 ·