Update the version CLI argument parser to accept "p2"

Open Beginner friendly
#166 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
rust
Domain
cli

Research direction

Start in src/bin/wasi-virt.rs at the CLI argument-processing code around lines 228-233 and inspect how the WASI version argument is parsed. Update the accepted format so p2 is recognized for the 0.2.x WASI series, then verify the CLI accepts p2 and still handles its documented version input correctly.

Written by the indexing model from the issue text.

Description

PR #164 modified WASI-Virt to work with WASI version "p2" (that is: any WASI version in the 0.2.x series). The CLI argument processing will need to be updated accordingly.

I think we should update src/bin/wasi-virt.rs to accept the p# formatted instead of 0.2.12. Otherwise it's a bit confusing misleading since you really only have 1 choice.

Originally posted by @ryan-surname-p in https://github.com/bytecodealliance/WASI-Virt/issues/164#issuecomment-5118228046

Dominant language
Rust
Stars
235
Forks
27
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bytecodealliance/WASI-Virt

All issues in bytecodealliance/WASI-Virt

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.