byt3bl33d3r/SILENTTRINITY

Stop command needs more user feedback when incorrectly used

Open

#97 opened on Sep 11, 2019

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Boo (427 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (2,340 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue Template

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

jeff@blue:~/dev/SILENTTRINITY$ git branch
* master
jeff@blue:~/dev/SILENTTRINITY$ git rev-parse HEAD
c3b397d85dbb471c4f202151d30100e4222215eb
  • SILENTTRINITY Version: Latest master branch
  • OS running the Client: Ubuntu 18.04 x64
  • Python Version Running the Client: Python 3.7.4+
  • OS running the TeamServer: Ubuntu 18.04 x64 (same system as client)
  • Python version running the Teamserver: Python 3.7.4 (same system as client)

Expected Behavior

The stop command from within the listeners context should stop the listener.

Current Behavior

Currently I wasn't able to stop a listener other than restarting teamserver.py

Failure Information

[1] ST ≫ listeners                                                                                                                                                                                                 
[1] ST (listeners) ≫ use http                                                                                                                                                                                      
[1] ST (listeners)(http) ≫ set Port 8000                                                                                                                                                                           
[1] ST (listeners)(http) ≫ list                                                                                                                                                                                    
[1] ST (listeners)(http) ≫ start                                                                                                                                                                                   
[1] ST (listeners)(http) ≫ list                                                                                                                                                                                    
┌Running────────────────────────────┐
│ Name │ URL                        │
├──────┼────────────────────────────┤
│ http │ http://10.153.143.148:8000 │
└──────┴────────────────────────────┘
[1] ST (listeners)(http) ≫ stop                                                                                                                                                                                    
[1] ST (listeners)(http) ≫ list                                                                                                                                                                                    
┌Running────────────────────────────┐
│ Name │ URL                        │
├──────┼────────────────────────────┤
│ http │ http://10.153.143.148:8000 │
└──────┴────────────────────────────┘
[1] ST (listeners)(http) ≫  

A separate terminal window shows python3 is still listening:

jeff@blue:~/dev/SILENTTRINITY$ lsof -ni | grep :8000
python3 12973 jeff   23u  IPv4 131287      0t0  TCP 10.153.143.148:8000 (LISTEN)

Steps to Reproduce

Start to finish is shown under Failure Information

Failure Logs

I can provide more information if needed, but I think the above is enough to replicate this from scratch.

Contributor guide