byt3bl33d3r/CrackMapExec

Logging discrepancies ?

Open

#534 opened on Feb 6, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,650 forks)batch import
help wanted

Repository metrics

Stars
 (7,931 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hey there, I was working on the source code of the ldap protocol (cme/protocols/ldap.py) and was wondering why some debug logging is made with self.logger.info and why other is made with logging.debug.

https://github.com/byt3bl33d3r/CrackMapExec/blob/6e57e4c3616b361fa44311389af2bbd7bb12839c/cme/protocols/ldap.py#L509

https://github.com/byt3bl33d3r/CrackMapExec/blob/6e57e4c3616b361fa44311389af2bbd7bb12839c/cme/protocols/ldap.py#L533

Is there a best practice to follow, which one should we use?

Contributor guide

Research direction
Examine the two logging calls in the ldap.py file and determine the intended use of self.logger.info vs logging.debug. Refer to project guidelines or common Python logging best practices to recommend standardization.
Tech stack
python
Domain
backendcli
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95