bumptech/glide

Support arbitrary LayoutManagers in RecyclerView integration package

Open

#493 opened on Jun 11, 2015

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Java (35,023 stars) (6,176 forks)batch import
enhancementgood first issuehelp wanted

Description

I was taking a look on RecyclerView integrations and ListPreloader implementation. If I haven't missed anything simply changing RecyclerToListViewScrollListener.java class to get the correct firstVisible, visibleCount and itemCount should be enough to create infinite scrolling for any other type of LayoutManager. Would you please correct me if I'm wrong.

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android RecyclerView basicsJavaGlide library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Examine RecyclerToListViewScrollListener.java in the Glide integration package. Determine how to adapt the scroll detection to work with any RecyclerView LayoutManager instead of assuming LinearLayoutManager. The key is to correctly compute firstVisible, visibleCount, and itemCount using LayoutManager methods. Consider contributing a fix that generalizes the listener.