bumptech/glide

Annotation processor uses class name as package name causing conflicts

Open

#2,860 opened on Feb 1, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (6,176 forks)batch import
bughelp wanted

Repository metrics

Stars
 (35,023 stars)
PR merge metrics
 (Avg merge 4d 10h) (11 merged PRs in 30d)

Description

Glide Version: 4.x

Integration libraries: N/A

Device/Android Version: N/A

Issue details / Repro steps / Use case background:

https://github.com/bumptech/glide/blob/eff228fcafc2a3e6077d15d0f2a995edf46f1f56/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/AppModuleProcessor.java#L84

See https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/glidelibrary/ZreirxaqMu0/QGhfJKJoBAAJ

Related: https://github.com/bumptech/glide/issues/2512

Glide load line / GlideModule (if any) / list Adapter code (if any):

package com.example;
class MyApp {
    @GlideModule
    static class MyModule {
    }
}

will generate com.example.MyApp.GlideApp; where MyApp will be a package and this conflicts with the outer class from the app.

Contributor guide

Research direction
Investigate the AppModuleProcessor to understand how it generates the package name for the GlideApp class. Check if the package name is derived from the enclosing class name and ensure it doesn't conflict with existing packages.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaAndroidannotation processing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70