bumptech/glide

[Feature request] Improve ViewPropertyTransition.Animator

Open

#2637 opened on Nov 24, 2017

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Java (35,023 stars) (6,176 forks)batch import
enhancementhelp wanted

Description

Glide Version: 4.3.1

When trying to understand some speed problems on low end devices, I found out that my custom animations where too slow sometimes and left the imageview in transient state too long. Meaning that recyclerview did not recycle the viewholder and created new viewholders everytime.

Fix is easy cancel animations on recycle :) But then trying to do that with current Glide API becomes complicated.

Workaround is to store a reference to viewproperty animator in a tag in the image then call the cancel in the adapter but this is quite ugly :)

I would suggest that ViewPropertyTransition.Animator is extended to have a cancel() or release() interface and have this interface called when clear is called on the target or view recycled

Contributor guide

Tech stack
javaandroid
Domain
mobileperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android development experienceFamiliarity with Glide's animation API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue requests adding a cancel() or release() method to ViewPropertyTransition.Animator. Start by examining the ViewPropertyTransition class and its Animator interface. Look at how animations are currently handled in Glide's target and request lifecycle. The discussion in the comments may reveal alternate proposals or concerns. Consider how to integrate cancellation with the existing clear() flow on targets.