bumbu/svg-pan-zoom

preventMouseEventsDefault stops working on Chrome 73

Open

#331 opened on Mar 20, 2019

View on GitHub
 (6 comments) (7 reactions) (0 assignees)JavaScript (1,585 stars) (383 forks)batch import
bughelp wanted

Description

Bug report

The option preventMouseEventsDefault disable scroll event, allowing wheel-zoom. With new Chrome 73 version: https://www.chromestatus.com/features/6662647093133312 they change to passive by default.

Expected behaviour

Zoom with mouse wheel without scrolling.

Actual behaviour

Mixed strange behaviour zoom+scroll.

Steps to reproduce the behaviour

  1. With Chrome/Chomium 73, go to demos, and open any.
  2. Resize your browser with a height < lion picture
  3. Use your mouse wheel over the picture

image

Configuration

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of JavaScript event listenersKnowledge of passive event listeners
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is caused by Chrome 73 making event listeners passive by default. Investigate the library's handling of mouse wheel events, specifically where `preventMouseEventsDefault` is implemented. The fix likely involves adding `{ passive: false }` to the `addEventListener` call for the 'wheel' event. Check the source code for event registration, likely in a file handling mouse interactions. Test in Chrome 73+ to ensure zoom works without scrolling.