bumbu/svg-pan-zoom

Add ability to pass ELEMENT to thumbnailViewer

Open

#264 opened on Oct 13, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,585 stars) (383 forks)batch import
enhancementhelp wanted

Description

Feature Request

  • Feature requested: Add the ability to pass an ELEMENT (not only an ID) to thumbnailViewer.
  • Reasons for adopting new feature: If we load SVG dynamically and want to use a thumbnailViewer, it's very hard to do so.
  • Is this a breaking change? It should not affect the functionality.

Thank you!

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the thumbnailViewer function, likely in src/thumbnail viewer.js or similar. Understand how it currently accepts an ID (string) and modify it to also accept an element node. Ensure backward compatibility and consider updating documentation and adding tests for both ID and element inputs.