bumbu/svg-pan-zoom

beforeZoom doesn't work as expected

Open

#168 opened on Nov 25, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,585 stars) (383 forks)batch import
bughelp wanted

Description

See http://jsfiddle.net/jwasinger/1nojj7ru/2/

Steps to Reproduce Bug:

Desired Functionality: No zooming should occur.

Erroneous Behavior: Zoom occurs.

This has only been tested/observed on Chrome (46.0.2490.86) running on OSX (10.10.5) thus far.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaScriptUnderstand SVG pan zoom library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The beforeZoom callback is expected to prevent zoom when returning false, but zoom still occurs. Investigate the source code in src/zoom.js or similar to see how beforeZoom is invoked and whether its return value is properly checked. Review the JSFiddle in the issue to reproduce the bug. Check if there is an existing fix or related issues.