bumbu/svg-pan-zoom

Method for only disabling the click listener's preventDefault()

Open

#156 opened on Oct 13, 2015

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (1,585 stars) (383 forks)batch import
enhancementhelp wanted

Description

Thank you for #123.

But having the new option affect all events goes a little far for my use case. Now if I set preventMouseEventsDefault: false, I scroll the screen when trying to pan via touch or zoom with the mousewheel.

Is there a way to prevent this?

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaScriptUnderstanding of event listeners
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the current implementation of event handling in the library, specifically how options like `preventMouseEventsDefault` are applied. The goal is to add a separate option to disable `preventDefault()` only for click listeners without affecting scroll/pan behavior. Review the codebase for event listener registration (likely in `src/svg pan zoom.js` or similar). Consider adding a new boolean option, e.g., `preventClickDefault`, and modify the click event listener to conditionally call `preventDefault()`. Ensure backward compatibility with existing options. Reference the existing PR #123 for context on the original change.