browsh-org/browsh

Fix bug in `webext/contrib/font_maker.py`

Open

#75 opened on Jul 10, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (15,996 stars) (455 forks)batch import
bughelp wanted

Description

See: https://milankragujevic.com/vip-drop-i-lekcije-u-odnosu-sa-korisnicima or any site with Chinese characters.

This site is the first non-Chinese site I've seen that is unable to hide the text during the graphics_builder screenshot phase.

Contributor guide

Tech stack
pythonjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Pythonunderstanding of web extension rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `webext/contrib/font maker.py` script, particularly the function that handles text hiding during the `graphics builder` screenshot phase. Test with a site containing Chinese characters to reproduce the issue. Check if the script correctly handles Unicode characters or if there is a fallback issue. Also review any comments or related issues in the repository for context.